-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to create a custom data type #121
Add option to create a custom data type #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I got some minor (nit) changes that I wish to see changed, but other than that we're good! I'm looking into running CI.
Thanks a lot for taking a look that fast ! Updated the PR with your suggestions |
SwiftLint found issues
Code Coverage Report
Generated by 🚫 Danger Swift against bde6940 |
Congratulations! 🎉 This was released as part of Release 2.6.0 🚀 Generated by GitBuddy |
@AvdLee Thanks a lot for approving and already releasing it. Really appreciate it 🙂 |
Hey all,
at first thanks a lot for this great library! I saw that it is not possible to easily extend
Mock.DataType
with custom ones. Therefore I try to solve this issue with this PR. I changed the type fromenum
tostruct
to give consumers the ability to create new instances ofDataType
.Furthermore I already created static variables on the
DataType
to not break any existing code with the types that were previously already in the library.I needed this particular feature, because I also want to test my network responses if they return a specific kind of content type.
I would very appreciate if you could have a look into this :) Also happy for any feedback here !