-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux support #116
Linux support #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great; thanks @vox-humana!
I wonder if we can run a build on Linux to verify that this works as expected and does not break in the future? |
SwiftLint found issues
Code Coverage Report
Generated by 🚫 Danger Swift against 9b2a6f7 |
We should indicate in the README on which platforms the framework is available. |
Congratulations! 🎉 This was released as part of Release 2.5.6 🚀 Generated by GitBuddy |
@BasThomas I am happy to add a simple Github action. Ideally it should also run tests via Also, not sure what's the current status of CI on the project. I see there is a Travis CI badge but seems like it is very outdated 🤔 |
Looks like it (and in the bridging header, but that's likely to be a CocoaPods artefact). We can either compare data, or use an
CI is run on Bitrise (using https://github.com/WeTransfer/WeTransfer-iOS-CI); I think that badge is indeed outdated 😂 Let us know if you'd be willing to tackle this; that'd be great! |
It definitely took me more than I initially thought 😅 #118 @BasThomas let's continue discussion there. |
These extra imports allow to use the library in tests on Linux. As an example I've enabled Linux tests in kean/Get library.
Also, removed unrelated warning that
swift build
showed: