Add a metrics kit logger #89
Conversation
AvdLee
requested review from
amirdew and
kevinrenskers
and removed request for
Boris-Em
Generated by 🚫 Danger Swift against 95c9596 |
| } | ||
|
|
||
| NSSetUncaughtExceptionHandler { exception in | ||
| MetricsMonitor.logExceptionUsingCallStackSymbols(exception, description: "Uncaught Exception") |
There was a problem hiding this comment.
Do I understand it correctly we now log crashes the old way and new way through metric kit? Because metric kit is only delivering reports once every 24 hours.
There was a problem hiding this comment.
Yes! MetricKit only delivers once per 24 hours, so you're not sure whether a crash is reported. Though, MetricKit reports much more than this exception handler. For example, EXC_BAD_ACCESS crashes don't get catched with this handler as there's no exception thrown.
Therefore, a combination of both is most useful
| extension MetricsMonitor: MXMetricManagerSubscriber { | ||
| @available(iOS 13.0, *) | ||
| func didReceive(_ payloads: [MXMetricPayload]) { | ||
| // We don't do anything with metrics yet. |
There was a problem hiding this comment.
Should we open an issue for this? There might be some valuable information we could log as well.
There was a problem hiding this comment.
I checked whether there was something obvious valuable, but there wasn't. Crashes really is the one thing we need now I think. Battery draining information and stuff won't really help in support issues.
Let me know if you disagree!
There was a problem hiding this comment.
Yeah I agree. The only one that comes to mind is background termination reason and memory termination.
|
Congratulations! 🎉 This was released as part of Release 1.10.0 🚀 Generated by GitBuddy |
For now, we're only logging crashes as the other diagnostics aren't easy to read and won't add as much value as the crashes payload does.
Fixes #86
Fixes #73