Add product names to report metadata. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsteppenbeck
requested review from
AvdLee,
Boris-Em and
kairadiagne
as code owners
AvdLee
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Looks good, this is a great addition!
For your info; if you add an issue in the PR description using one of the closing keywords the issue will be linked and closed once the PR is merged.
I've now changed "Issue 60" to "Fixes 60" for you 🙂
Diagnostics.framework: Coverage: 77.12
Generated by 🚫 Danger Swift against a953948 |
@AvdLee OK, good to know! |
AvdLee
suggested changes
Feb 28, 2020
AvdLee
approved these changes
Feb 28, 2020
|
Great stuff, merging in! |
|
Congratulations! 🎉 This was released as part of Release 1.6.0 🚀 |
ghost
mentioned this pull request
|
Happy to help! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only includes most recent iPhone models.
Fixes #60