Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logDescription of MXCrashDiagnostic with human-readable exception type and signal #151

Merged

Conversation

edorphy
Copy link
Contributor

@edorphy edorphy commented May 31, 2023

#149

Updated the logDescription of the MXCrashDiagnostic to print the human-readable lookups for the exception type and signals defined in iOS SDK header files using custom string interpolations.

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Copy link
Contributor

@raphkoebraam raphkoebraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented May 31, 2023

Warnings
⚠️

Consider to place some MARK: lines for Sources/Logging/Loggable.swift, which is over 300 lines big.

Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.211 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.012s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.007s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.007s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 63.75% ⚠️

SwiftLint found issues

Severity File Reason
Warning Loggable.swift:203 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning Loggable.swift:247 Use shorthand syntax for optional binding (shorthand_optional_binding)

Generated by 🚫 Danger Swift against ffdb980

@AvdLee
Copy link
Contributor

AvdLee commented May 31, 2023

@edorphy thanks for your contribution!

Our repository requires signed commits. Would it be possible for you to enable signed commits and recommit using the following command:

git rebase --exec 'git commit --amend --no-edit -n -S' master
git push --force

You can read more about setting up signed commits here.

@edorphy edorphy force-pushed the features/crash-diagnostic-loggable branch from d36b161 to de8981f Compare May 31, 2023 14:18
@edorphy
Copy link
Contributor Author

edorphy commented Jun 1, 2023

I fixed the SwiftLint warnings and errors that I introduced :D. Should be good now.

@edorphy edorphy requested a review from AvdLee June 1, 2023 01:13
Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks a lot for taking care of signing your commits! Let's go!

@AvdLee AvdLee merged commit c3816d3 into WeTransfer:master Jun 1, 2023
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.5.0 🚀

Generated by GitBuddy

@edorphy edorphy deleted the features/crash-diagnostic-loggable branch March 20, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants