Let developer set App Store region for UpdateAvailableInsight #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubenfer
requested review from
amirdew,
kairadiagne,
AvdLee,
BasThomas and
raphkoebraam
as code owners
Code Coverage Report
Generated by 🚫 Danger Swift against 0632a78 |
AvdLee
suggested changes
Oct 17, 2022
There was a problem hiding this comment.
Thanks a lot for your first contribution, great job!
This is actually a great find and something we should improve 💯. How about using the user's region instead? Ideally, we would even be able to read out the App Store region for the user, so it exactly aligns with the user's environment.
|
Good idea! Just updated to use device region. |
Rubenfer
requested review from
AvdLee
and removed request for
amirdew,
BasThomas,
raphkoebraam and
kairadiagne
AvdLee
approved these changes
Oct 18, 2022
|
Congratulations! 🎉 This was released as part of Release 4.3.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
just started using this library in one of my apps and noticed the report doesn't includes the update available smart insights because my app is only available in Spain and it tries to retrieve metadata from Brazilian App Store.
In this PR I include an optional parameter to set the iTunes region in the create report method. Also including the option to set custom report filename.
Congratulations for this great package.