Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 webpack 构建 publicPath 使用相对路径,导致 css 里面依赖资源路径异常问题 #237

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: 修复 webpack 构建 publicPath 使用相对路径,导致 css 里面依赖资源路径异常问题 #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/fes-builder-webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@
"html-webpack-tags-plugin": "^3.0.0",
"less": "^4.1.3",
"less-loader": "^11.1.0",
"mini-css-extract-plugin": "^2.7.5",
"mini-css-extract-plugin": "^2.8.1",
"postcss": "^8.4.33",
"postcss-flexbugs-fixes": "^5.0.2",
"postcss-loader": "^7.1.0",
"postcss-safe-parser": "^6.0.0",
"style-loader": "^3.3.2",
"terser-webpack-plugin": "^5.3.6",
"vue-loader": "^17.0.1",
"webpack": "^5.87.0",
"vue-loader": "^17.4.2",
"webpack": "^5.90.3",
"webpack-5-chain": "^8.0.1",
"webpack-bundle-analyzer": "^4.4.0",
"webpack-dev-server": "^4.15.1",
Expand Down
10 changes: 8 additions & 2 deletions packages/fes-builder-webpack/src/plugins/common/webpackConfig/css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ function createRules({ isDev, webpackConfig, config, lang, test, loader, options
function applyLoaders(rule, cssLoaderOption = {}) {
if (isDev || !config.extraCSS) {
rule.use('extra-css-loader').loader(require.resolve('style-loader')).options(Object.assign({}, styleLoaderOption));
} else {
}
else {
const loaderOptions = config.extraCSS?.loader ?? {};

if (!loaderOptions.publicPath && config.publicPath.startsWith('./')) {
loaderOptions.publicPath = '../';
}
rule.use('extra-css-loader')
.loader(require('mini-css-extract-plugin').loader)
.options(config.extraCSS?.loader ?? {});
.options(loaderOptions);
}

rule.use('css-loader')
Expand Down
1 change: 0 additions & 1 deletion packages/fes-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@fesjs/plugin-sass": "workspace:*",
"@fesjs/plugin-swc": "workspace:*",
"@fesjs/plugin-watermark": "workspace:*",
"@fesjs/plugin-windicss": "workspace:*",
"core-js": "3.29.1",
"pinia": "^2.0.33",
"vue": "^3.2.47"
Expand Down
4 changes: 4 additions & 0 deletions packages/fes-template/src/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.page {
height: 1000px;
background-image: url('~@/images/hello.png');
}
5 changes: 0 additions & 5 deletions packages/fes-template/src/global.scss
View file
Open in desktop

This file was deleted.

Binary file added packages/fes-template/src/images/hello.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/fes-template/src/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ function go() {
}
</script>

<style>
<style lang="less">
.page {
height: 1000px;
background-image: url('@/images/hello.png');
}
</style>
Loading