-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make socket path unique #2490
Make socket path unique #2490
Conversation
If we're going to do this, move the socket to XDG_RUNTIME_DIR :) |
|
@killown I think you should open a PR. You're clearly doing a much better job than I can. |
I don't think we need the pid when the socket is in $XDG_RUNTIME_DIR, without the pid I also think it is just a little bit simpler to find the socket when running from somewhere where $WAYFIRE_SOCKET is not set. Otherwise @killown's patch lgtm, I don't know why you won't send a pr :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Make socket path unique * Use XDG_RUNTIME_DIR to create ipc socket * Fix runtime_dir not declared
The solution proposed by @killown to make the socket path unique. I have tested this and confirm that it works.