Set default decoration mode when it is adjusted at runtime #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Scott Moreau <[email protected]>
wb9688
force-pushed
the
dynamic-deco-mode
branch
from
89f2a72 to
2d62344
Compare
|
By the way it should be possible to make existing windows switch decorations as well, by sending them all a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This calls
wlr_server_decoration_manager_set_default_modeagain when the settingcore/preferred_decoration_modeinwayfire.iniis updated during runtime.I figured out why it didn't work before and tried to implement that, but couldn't do that with valid C++ syntax due to my lack of C++ knowledge, so @soreau made the patch with proper C++ syntax, which is why I added him as co-author to the commit.
I tested this PR and it works completely as expected. Only with this PR, you will notice a bug in GTK, which I submitted a MR for at https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7475