Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check wlroots features and fail if required ones are missing #2226

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

parona-source
Copy link
Contributor

DRM, GLES2, libinput and session are all expected to be present unconditionally in wlroots-full.hpp which is a part of the wayfire api

https://github.com/WayfireWM/wayfire/blob/master/src/api/wayfire/nonstd/wlroots-full.hpp

@parona-source parona-source marked this pull request as draft March 18, 2024 18:01
* This works for both dependencies and subprojects.
* Error out if required backends and renderers are missing.

Signed-off-by: Alfred Wingate <[email protected]>
@parona-source parona-source marked this pull request as ready for review March 18, 2024 18:08
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the dependencies for the GLES renderer in the README.

README.md Show resolved Hide resolved
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit dba4f22 into WayfireWM:master Mar 21, 2024
4 checks passed
ammen99 added a commit that referenced this pull request Mar 22, 2024
This is a regression introduced in #2226
ammen99 added a commit that referenced this pull request Mar 22, 2024
This is a regression introduced in #2226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants