output: Add bit depth property #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently supports 8 and 10 bpc. Fixes #2103.
ammen99
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM. I pushed two small changes, mostly was wondering why we need the invalid format at the end of the list? When we have a std::vector, we can simply iterate over the list and don't need the last invalid format, right @soreau? (asking to make sure I didn't break something I don't understand)
Yes, your changes LGTM too. 👍 |
ammen99
pushed a commit
that referenced
this pull request
Mar 13, 2024
* output: Add bit depth property Currently supports 8 and 10 bpc. Fixes #2103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports 8 and 10 bpc.
Fixes #2103.