Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subsurfaces to the back that are meant to be below the parent surface #2099

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

soreau
Copy link
Member

@soreau soreau commented Jan 17, 2024

Most applications add their subsurfaces above the parent, so we were blindly adding them to the front. This patch checks if the subsurface should be below, and adds it to the back in that case, or else adds it to the front.

Fixes #1206.
Fixes #1615.

…face

Most applications add their subsurfaces above the parent, so we were blindly
adding them to the front. This patch checks if the subsurface should be
below, and adds it to the back in that case, or else adds it to the front.

Fixes #1206.
Fixes #1615.
@soreau soreau changed the title Add subsurfaces to the back that are meant to be below the parent sur… Add subsurfaces to the back that are meant to be below the parent surface Jan 17, 2024
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@ammen99 ammen99 merged commit 5bc6deb into master Jan 17, 2024
8 checks passed
@ammen99 ammen99 deleted the subsurface-fix branch January 17, 2024 21:21
lilydjwg pushed a commit to lilydjwg/wayfire that referenced this pull request Jan 21, 2024
…face (WayfireWM#2099)

Most applications add their subsurfaces above the parent, so we were blindly
adding them to the front. This patch checks if the subsurface should be
below, and adds it to the back in that case, or else adds it to the front.

Fixes WayfireWM#1206.
Fixes WayfireWM#1615.
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
…face (#2099)

Most applications add their subsurfaces above the parent, so we were blindly
adding them to the front. This patch checks if the subsurface should be
below, and adds it to the back in that case, or else adds it to the front.

Fixes #1206.
Fixes #1615.
xiaohuirong added a commit to xiaohuirong/wayfire that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black screen on waydroid Handle subsurfaces below and above main surface
3 participants