Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decor: Don't put minimize buttons on child views #2057

Merged
merged 2 commits into from
Jan 15, 2024
Merged

decor: Don't put minimize buttons on child views #2057

merged 2 commits into from
Jan 15, 2024

Conversation

soreau
Copy link
Member

@soreau soreau commented Dec 7, 2023

Fixes #705.

@soreau
Copy link
Member Author

soreau commented Dec 7, 2023

Tested with VLC.

ammen99
ammen99 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder whether we shouldn't also add a check or at least log an error in case a view with a parent is minimized?

@soreau
Copy link
Member Author

soreau commented Dec 9, 2023

LGTM. I wonder whether we shouldn't also add a check or at least log an error in case a view with a parent is minimized?

At what time point or source location?

@ammen99
Copy link
Member

ammen99 commented Dec 20, 2023

At what time point or source location?

Here would be a good place I guess:
https://github.com/WayfireWM/wayfire/blob/master/src/view/toplevel-view.cpp#L202

@ammen99 ammen99 merged commit 328398a into master Jan 15, 2024
8 checks passed
@ammen99 ammen99 deleted the fix-705 branch January 15, 2024 08:52
lilydjwg pushed a commit to lilydjwg/wayfire that referenced this pull request Jan 21, 2024
@soreau @lilydjwg
decor: Don't put minimize buttons on child views (WayfireWM#2057)
4f69978 
* decor: Don't put minimize buttons on child views

Fixes WayfireWM#705.

* do not allow minimizing views with toplevel parents
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
@soreau @ammen99
decor: Don't put minimize buttons on child views (#2057)
9515f8d 
* decor: Don't put minimize buttons on child views

Fixes #705.

* do not allow minimizing views with toplevel parents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow minimize for child views
2 participants
@soreau @ammen99