Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc-rules: Add list-outputs function #2031

Merged
merged 1 commit into from
Nov 26, 2023
Merged

ipc-rules: Add list-outputs function #2031

merged 1 commit into from
Nov 26, 2023

Conversation

soreau
Copy link
Member

@soreau soreau commented Nov 26, 2023

This can be used by scripts like trailfocus.py, where views need to be divided by outputs. The list can be cobbled together from list_views() and view['output'], but that is a hack, at best.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to separate the code from the call for querying a single output to a function and then give the same information with the same structure in both list-outputs and output-info, otherwise lgtm

This can be used by scripts like trailfocus.py, where views need to be
divided by outputs. The list can be cobbled together from list_views()
and view['output'], but that is a hack, at best.
@soreau
Copy link
Member Author

soreau commented Nov 26, 2023

I think it might make sense to separate the code from the call for querying a single output to a function and then give the same information with the same structure in both list-outputs and output-info, otherwise lgtm

Done.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit 97e6702 into master Nov 26, 2023
8 checks passed
@ammen99 ammen99 deleted the ipc-list-outputs branch November 26, 2023 19:28
ammen99 pushed a commit that referenced this pull request Mar 13, 2024
This can be used by scripts like trailfocus.py, where views need to be
divided by outputs. The list can be cobbled together from list_views()
and view['output'], but that is a hack, at best.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants