Unbreak build on FreeBSD #1939
Merged
Unbreak build on FreeBSD #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2bf7b278d17In file included from plugins/single_plugins/place.cpp:1:
In file included from src/api/wayfire/signal-provider.hpp:7:
src/api/wayfire/nonstd/safe-list.hpp:144:35: error: implicit instantiation of undefined template 'std::vector<std::optional<wf::signal::connection_base_t *>>'
std::vector<std::optional<T>> list;
^
src/api/wayfire/signal-provider.hpp:148:36: note: in instantiation of template class 'wf::safe_list_t<wf::signal::connection_base_t *>' requested here
for (auto& [id, connected] : typed_connections)
^
/usr/include/c++/v1/iosfwd:260:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
^
test/misc/safe-list-test.cpp:2:10: fatal error: 'doctest/doctest.h' file not found
#include <doctest/doctest.h>
^~~~~~~~~~~~~~~~~~~
ammen99
approved these changes
Oct 7, 2023
|
Thanks, I'll update the 0.8.0 release to include these commits. |
|
Updated the release as well - I hope it doesn't break things for anybody since the release was very soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by e2bf7b2. Found on FreeBSD 13.2 (inside poudriere jail).