Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] Do not show snap previews for halves and quarters of the screen when grid is disabled #2403

Closed
wb9688 opened this issue Jul 23, 2024 · 2 comments · Fixed by #2404
Closed

[move] Do not show snap previews for halves and quarters of the screen when grid is disabled #2403

wb9688 opened this issue Jul 23, 2024 · 2 comments · Fixed by #2404
Labels
bug low-priority Issues that aren't likely to be resolved soon PRs-welcome Issues which are unlikely to be fixed unless someone sends a PR

Comments

@wb9688
Copy link
Contributor

wb9688 commented Jul 23, 2024

Describe the bug
move without grid causes snapping to maximize instead of just not snapping at all.

To Reproduce
Steps to reproduce the behavior:

  1. Enable plugin move, but not grid
  2. Drag a window to the left
  3. It shows the blue thingy to suggest snapping and when you drop it, the window maximizes

Expected behavior
When grid is not enabled, the blue thingy to suggest snapping should not appear and the window should definitely not be maximized.

Wayfire version
44e1fa9
@wb9688 wb9688 added the bug label Jul 23, 2024
@ammen99
Copy link
Member

ammen99 commented Jul 23, 2024

This is expected behavior. Grid provides this functionality. At most, we could make move not show the previews.

@ammen99 ammen99 changed the title move without grid causes snapping to maximize [move] Do not show snap previews for halves and quarters of the screen when grid is disabled Jul 23, 2024
@ammen99 ammen99 added low-priority Issues that aren't likely to be resolved soon PRs-welcome Issues which are unlikely to be fixed unless someone sends a PR labels Jul 23, 2024
@wb9688
Copy link
Contributor Author

wb9688 commented Jul 23, 2024 •
edited
Loading

It's not expected behavior to show the blue indicator nor to maximize the window then. If grid is disabled, the blue indicator shouldn't be shown and it should not just maximize the window (except when dragged to the top I guess).

soreau added a commit that referenced this issue Jul 24, 2024
@soreau
move: Check if grid is enabled before activating edges on drag
96091e5 
Before, dragging to an edge with move enabled and grid disabled would
result in the indicator being drawn for the slot but always maximized.
Fix this by emitting a signal that grid or another plugin can tell move
the request is handled, so move can try gridding. In this implementation,
we just hard code top to maximize if grid is disabled.

Fixes #2403.
@soreau soreau mentioned this issue Jul 24, 2024
Merged
soreau added a commit that referenced this issue Jul 24, 2024
@soreau
move: Check if grid is enabled before activating edges on drag
9deb60e 
Before, dragging to an edge with move enabled and grid disabled would
result in the indicator being drawn for the slot but always maximized.
Fix this by emitting a signal that grid or another plugin can tell move
the request is handled, so move can try gridding. In this implementation,
we just hard code top to maximize if grid is disabled.

Fixes #2403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug low-priority Issues that aren't likely to be resolved soon PRs-welcome Issues which are unlikely to be fixed unless someone sends a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move: Check if grid is enabled before activating edges on drag WayfireWM/wayfire
2 participants
@ammen99 @wb9688