Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NF1 data submodule #66

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Updated NF1 data submodule #66

merged 2 commits into from
Aug 7, 2024

Conversation

MattsonCam
Copy link
Member

@MattsonCam MattsonCam commented Aug 7, 2024

This pr focuses on updating the NF1 data submodule, creating a reference from the nf1_cellpainting_data repo. This is in response to issue #63. Any constructive feedback is welcome.

Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice small change! I confirmed this is updated to the same commit currently in the nf1_cellpainting_data repo. Just FYI there will be at least one more PR for the nf1_cellpainting_data repo prior to minting, so you might have to do this again.

Once you address comments, feel free to merge!

nf1_painting_repo Show resolved Hide resolved
@MattsonCam
Copy link
Member Author

Thanks @jenna-tomkinson, merging now!

@MattsonCam MattsonCam merged commit 1ee02ec into main Aug 7, 2024
@MattsonCam MattsonCam deleted the update_nf1_data_submodule branch August 7, 2024 23:28
@MattsonCam MattsonCam mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants