-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell Count EDA of NF1 single-cell plate data #60
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't see anything glaring in the code that looks off, everything is all put together really well in functions. I left a few comments for you to address prior to merging. Nice job! 🎉
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/nbconverted/single_cell_fs_plate_cell_count_eda.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_eda_analyses/plate_3_figures/plate_3_cells_missing_columns.png
Outdated
Show resolved
Hide resolved
Thanks @jenna-tomkinson for reviewing, merging now! |
In this pr, we explore the NF1 single-cell data by visualizing plate cell count distributions. Additional eda analysis, such as those exploring cell morphology features are included in this repo and the nf1 cell painting repo. Any constructive feedback given while reviewing this pr is appreciated.