Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main figure 2 #44

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

jenna-tomkinson
Copy link
Member

Add main figure 2

In this PR, main figure 2 is generated and ready to be nit-picked! Thanks!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gwaybio
Copy link
Member

gwaybio commented Jun 10, 2024

Nitpicks

The way the figure is currently laid out places the primary focus on different plates. I'm not sure that's the message we want to state! I think the message needs to focus more on genotype. We can show in a supplemental figure the influence of plate.

So, my recommendations are to:

Panel A

  • Show only one UMAP, make genotype different colors

Panel B

  • Show only one facet, with the following categories for curves: 1) Same genotype same plate, 2) Same genotype different plate, 3) Different genotype same plate, 4) Different genotype different plate

We also should dig a bit into the bimodal curves for plate 3 prime - super interesting!!

Other

I wonder if there is room here to add a descriptive panel. Perhaps a new panel A (the others become B and C), which can do some heavy work describing how many cells of either genotype we analyzed total (and per plate). I imagine a bar chart would be good.

We can chat about this (and all other suggestions) separately as well! Looking good!

@jenna-tomkinson jenna-tomkinson requested a review from gwaybio June 11, 2024 16:31
@gwaybio
Copy link
Member

gwaybio commented Jun 11, 2024

Looking much better! A few more nitpicks

Panel A

  • Can you add (to the beginning sets of bars) a Total (indicating all plates)
  • Can you add text to the top of each bar indicating the exact count?
  • I would recommend recoding the plate numbers to reduce confusion. Maybe name them plates A-D?
  • The bars for plate 5 do not show siRNA treatments, right?

Panel B

Panel C

  • I'm a bit thrown off by the colors... maybe tweaking this to have only two colors and showing a ggridge facet of same plate and different plate? Does this make sense?
  • The legend title "Combination" lacks specificity. Perhaps (and once you shift the plot slightly as I recommend above), the title can be: Is the\npairwise\ncomparison\nfrom the\nsame genotype? (or something super specific liek this)

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nitpick - otherwise LGTM and please merge when you're happy!

I was hoping to see totals from all plates for each genotype (not totals per plate)

@jenna-tomkinson
Copy link
Member Author

@gwaybio Thank you for the reviews! All nit-picks have been addressed. I will be merging now!

@jenna-tomkinson jenna-tomkinson merged commit db4fb14 into WayScience:main Jun 11, 2024
@jenna-tomkinson jenna-tomkinson deleted the add_main_figure_2 branch June 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants