Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plate 5 aggregating cells and correlating wells #22

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

MattsonCam
Copy link
Member

In this pr, I use cameron's method to aggregate cells to the well level and correlate wells of both different genotypes and the same genotype using cell profiler feature vectors. This is the first stage. In later stages this data will be used for further analysis. Please let me know have any questions or suggestions.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR overall. I am requesting changes due to the use of OOP. I think helper functions might simplify things here. Please feel free to push back and provide rationale and I will gladly approve. :)

@MattsonCam
Copy link
Member Author

Hey @MikeLippincott, I finished addressing your comments, please let me know if there is anything else you'd suggest I change.

Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing comments!

@MattsonCam
Copy link
Member Author

Thanks @MikeLippincott, merging now!

@MattsonCam MattsonCam merged commit 7661091 into main Feb 2, 2024
@MattsonCam MattsonCam deleted the plate_5_cameron_agg_well_corr branch February 2, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants