-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plate 5 aggregating cells and correlating wells #22
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR overall. I am requesting changes due to the use of OOP. I think helper functions might simplify things here. Please feel free to push back and provide rationale and I will gladly approve. :)
...is/plate_5_characteristics/nbconverted/plate_5_sc_feature_selected_camerons_agg_well_corr.py
Outdated
Show resolved
Hide resolved
...is/plate_5_characteristics/nbconverted/plate_5_sc_feature_selected_camerons_agg_well_corr.py
Show resolved
Hide resolved
...is/plate_5_characteristics/nbconverted/plate_5_sc_feature_selected_camerons_agg_well_corr.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_5_characteristics/utils/CorrelateAggWells.py
Outdated
Show resolved
Hide resolved
Hey @MikeLippincott, I finished addressing your comments, please let me know if there is anything else you'd suggest I change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing comments!
Thanks @MikeLippincott, merging now! |
In this pr, I use cameron's method to aggregate cells to the well level and correlate wells of both different genotypes and the same genotype using cell profiler feature vectors. This is the first stage. In later stages this data will be used for further analysis. Please let me know have any questions or suggestions.