-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bulk correlation figure from plate 4 analysis #11
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @gwaybio! I left a few comments. I think this pr may still be relevant to the figure of the paper, so I provided a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also annotate the correlation value corresponding to the dashed horizontal line. It seems obvious the dashed line is at a correlation of zero, so maybe not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the whiskers seem to be hidden behind points, but I think it doesn't detract visually from the plots, since there aren't too many points in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could also be represented as violin plots, but a concise visualization may be better here
Thanks for the review @MattsonCam - Sorry that I missed it and am returning to it so late. Thanks specifically for the figure recommendations. Given that @jenna-tomkinson will be regenerating this figure to be publication ready, I will save time by ignoring these suggestions for now. Jenna, please take these into consideration when generating the official figure. Thanks! Merging now! |
Preliminary figures visualizing correlation of bulk profiles in the plate 4 NF1 siRNA experiment.
This PR is pending several developments:
✅ @jenna-tomkinson: WayScience/nf1_schwann_cell_painting_data#21
✅ @MattsonCam refactor bulk data processing to use pycytominer (Jenna's contribution above)
✅ @MattsonCam add correlations to scramble for negative control
✅ @gwaybio rerun this notebook to incorporate the new profiles and new scramble correlations