Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk correlation figure from plate 4 analysis #11

Merged
merged 10 commits into from
May 28, 2024

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jul 24, 2023

Preliminary figures visualizing correlation of bulk profiles in the plate 4 NF1 siRNA experiment.

This PR is pending several developments:

@jenna-tomkinson: WayScience/nf1_schwann_cell_painting_data#21
@MattsonCam refactor bulk data processing to use pycytominer (Jenna's contribution above)
@MattsonCam add correlations to scramble for negative control
@gwaybio rerun this notebook to incorporate the new profiles and new scramble correlations

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gwaybio gwaybio requested a review from MattsonCam August 7, 2023 18:37
Copy link
Member

@MattsonCam MattsonCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gwaybio! I left a few comments. I think this pr may still be relevant to the figure of the paper, so I provided a review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also annotate the correlation value corresponding to the dashed horizontal line. It seems obvious the dashed line is at a correlation of zero, so maybe not necessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the whiskers seem to be hidden behind points, but I think it doesn't detract visually from the plots, since there aren't too many points in my opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could also be represented as violin plots, but a concise visualization may be better here

@gwaybio
Copy link
Member Author

gwaybio commented May 28, 2024

Thanks for the review @MattsonCam - Sorry that I missed it and am returning to it so late.

Thanks specifically for the figure recommendations. Given that @jenna-tomkinson will be regenerating this figure to be publication ready, I will save time by ignoring these suggestions for now. Jenna, please take these into consideration when generating the official figure. Thanks!

Merging now!

@gwaybio gwaybio merged commit f32b3d3 into WayScience:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants