-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Workflow: cp_process_singlecells
!
#37
Conversation
Co-authored-by: Dave Bunten <[email protected]>
Co-authored-by: Dave Bunten <[email protected]>
Hello @axiomcura @jenna-tomkinson @d33bs Hopefully I have attended all your comments and suggestions. Ready for another review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR spawned several other issues!
Of the ones it spawned, which are highest priority in terms of handing this off to @jenna-tomkinson to play with?
It's too hard to tell. My best bet is which ever @jenna-tomkinson finds the most annoying. 😅 |
oh gotcha! So you're saying after this is merged, she can have at it? (i.e. no other issues need addressing?) |
I have been using the I think one issue would be trying to run |
Gotcha! Ok, perhaps this is the next priority to tackle, but it doesn't necessarily mean that Jenna has to wait.
Glad to hear it!! I wonder if you can contribute this directly then... what do you think? |
I think the plan right now is: I send it to @jenna-tomkinson , she writes some issues in the issues section in the Repo and I attend those a first priority issues to take care off.
Don't mind at all. @jenna-tomkinson and I can sit together, tinker with the config files to generate high quality features :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for addressing the comments and for making many changes in addition to the new issues! I left a few minor comments + responses and overall felt this LGTM, respecting your decision on when it's best to merge.
@@ -1,7 +1,7 @@ | |||
cytotable_convert: | |||
params: | |||
dest_datatype: parquet | |||
source_datatype: null | |||
source_datatype: sqlite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking: does this mean CytoSnake is tightly coupled to SQLite source data input for CytoTable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now yes. But in the future CSV
and NPZ
support will be added into the cytotable_convert.yaml
module
About
This PR introduces a new a workflow that is based on @jenna-tomkinson single cell feature extraction analysis
What’s new
cytotable_convert.smk
sqlite
files intoparquet
files. For more information aboutCytoTable
, please look at the reposqlite
files intoparuquet
files by usingcytostable_convert.smk
modulepycytominer
's normalization function within thenormalize.smk
modulepycytominer
's feature extraction function in thefeature_selection.smk
moduleconfigs/wl_configs/cp_process_singlecells.yaml
Usage
To use this workflow first one must initalize the data set for
NOTE: Make sure to replace the file names with your own file names.
Where:
-d
is the dataset, it can also be a list of datasets-m
refers to the metadata folder-b
refers to the barcodes files, however, this is optional. If your datasets do not come with barcodes, then this will be defaulted toNone
This will make
CytoSnake
recognize that in the current directory you are in is theProjectDirectory
once the initialization step is complete, then you can use
CytoSnake
'srun
mode to execute thecp_process_singlecells
workflowIn your
ProjecDirectory
, a new directory will appear titled asresults
. That is where all the outputs will be saved.data
folderAnd that’s it!
Change configurations.
To change the
cp_process_singlecells
configs, go toconfigs/wl_configs/cp_process_singlecells.yaml
fileThe structure of the config is:
To change the parameters, change the values to each keyword under the
params
section. Make sure the inputs are valid. Please refer to the software's documentation..CytoSnake
cannot preemptively check if the new parameters are valid before executing the workflow.