refactor: ui and texts minor enhancements #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `finance-quick-transfer-modal.tsx` to use `value` as a fallback if `amount` is not greater than 0. - Ensures accurate MMC amount is displayed in the transfer message.
- **`profile-header.tsx`**: Removed direct usage of `ProfileTransfer` and its transfer button for other user profiles. - **`profile-transfer.tsx`**: Introduced tooltip behavior and additional UI improvements for the transfer button. Enhanced interactivity with popovers and streamlined styling. - **`profile-toolbar.tsx`**: Re-integrated `ProfileTransfer` component for authenticated sessions in the updated toolbar context. These changes improve the usability and accessibility of profile transfer actions while refining the user interface and overall experience.
- Updated `finance-display-profile-info.tsx` to include a `fontSize` style of `1.3rem` for the profile display name. - Ensures improved readability for profile names in 'profile' mode.
- Introduced `trimPublicationContentExtraText` in `src/utils/text-transform.ts`. This utility trims text based on specific special characters. - Updated `publication-details-view.tsx` to utilize this trimming utility when rendering publication content with Markdown.
This was
linked to
issues
Jan 31, 2025
Jadapema
requested changes
Feb 2, 2025
|
|
||
| // If none of the special characters are found, return the original text | ||
| return text; | ||
| }; |
There was a problem hiding this comment.
Right now, if a special character appears at the beginning or in the middle of the description, the entire text (or a large portion of it) might get removed. Could we avoid this by splitting the logic? Maybe we could have one function that removes only specific characters and uncommon words from an array, and another one dedicated to removing emails. This way, we reduce the risk of losing relevant information.
There was a problem hiding this comment.
@jacob solve as discused during last meeting
- Removed `ERRORS.BUNDLER_UNAVAILABLE` from `src/utils/notifications/errors.ts`. - Added `WARNING.BUNDLER_UNAVAILABLE` to `src/utils/notifications/warnings.ts` with updated message. - Replaced `notifyError` with `notifyWarning` for bundler unavailability in `src/hooks/use-account-session.ts`. This transition classifies the bundler unavailability as a warning, ensuring better contextual distinction for session-related notifications.
- Refactored `trimPublicationContentExtraText` to modularize logic: - Extracted `removeSpecialChars` function for removing predefined patterns. - Added `detectEmail` and `removeEmail` functions to handle email detection and removal. - Updated logic to ensure processed text ends with a period. - Improved readability and maintainability by splitting responsibilities.
…mprovement # Conflicts: # src/sections/finance/components/finance-display-profile-info.tsx # src/sections/finance/components/finance-quick-transfer-modal.tsx # src/sections/publication/view/publication-details-view.tsx
- Added a detailed `emailRegex` with extended documentation in `text-transform.ts` to centralize email validation logic. - Updated `detectEmail` and `removeEmail` functions to reuse the new `emailRegex` constant, improving maintainability and consistency.
- Updated `emailRegex` in `src/utils/text-transform.ts` to include word boundary markers (`\b`) at both ends. - This change ensures more accurate email matching and prevents partial matches in strings.
- Updated `text-transform.ts` to replace `charAt` and length check with `endsWith` for verifying the presence of a period. - This improves code readability and leverages a more intuitive string method.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across different sections of the codebase, focusing on enhancing UI components, improving text processing, and refactoring code for better usability. The most important changes include updates to the
ProfileTransfercomponent, modifications to thePublicationDetailsView, and adjustments to theFinanceQuickTransferModal.UI Enhancements:
src/sections/user/profile-transfer.tsx: Enhanced theProfileTransfercomponent by adding a tooltip and improving the button styling. [1] [2]src/sections/user/profile-toolbar.tsx: Moved theProfileTransfercomponent to the toolbar for better accessibility. [1] [2]Text Processing Improvements:
src/utils/text-transform.ts: Added a new functiontrimPublicationContentExtraTextto trim additional content from publication strings based on specific special characters.src/sections/publication/view/publication-details-view.tsx: Updated thePublicationDetailsViewto use the newtrimPublicationContentExtraTextfunction for processing publication content. [1] [2]Finance Component Updates:
src/sections/finance/components/finance-quick-transfer-modal.tsx: Modified therawDescriptionto handle both positive and non-positive amounts correctly.src/sections/finance/components/finance-display-profile-info.tsx: Adjusted the font size for the profile display name in theFinanceDisplayProfileInfocomponent.Code Refactoring:
src/sections/user/profile-header.tsx: Removed theProfileTransfercomponent from the profile header to streamline the UI. [1] [2]