[Feat] run func timeout use std::time::Duration

[L-jasmine]

No description provided.

[juntao]

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

---

Overall, the pull request introduces several changes related to handling timeouts and asynchronous operations. The changes include replacing the timeout parameter with the deadline parameter of type std::time::SystemTime in the TimeoutFiberFuture struct, and replacing the timeout parameter with the timeout parameter of type std::time::Duration in various functions of the Executor, Func, and Vm structs.

The potential problems in the code include handling errors when calculating the timeout duration, assuming the timeout value is already in seconds and casting it to i64 without validation, setting a minimum timeout of 100 milliseconds in the TimeoutFiberFuture struct, not handling errors when setting the timer, potential duplication of similar functionality in different structs, and lack of documentation explaining the use of the deadline parameter in the TimeoutFiberFuture struct.

Additionally, the pull request includes updates to the API documentation and introduces a new async_state argument to multiple functions. However, there is a lack of context and explanation for these changes, requiring further documentation or code comments to clarify their purpose.

In conclusion, the pull request addresses timeout handling and asynchronous operations, but it lacks necessary error handling, validation, and documentation to ensure the reliability and understandability of the code.

Details

Commit 1b0bf586540c17e79fc96a07562ab9fb10bdae40

Key changes in this PR:

• The timeout parameter in the on_fiber function of the TimeoutFiberFuture struct has been replaced with the deadline parameter of type std::time::SystemTime.
• The timeout parameter in the call_func function of the Executor struct has been replaced with the timeout parameter of type std::time::Duration.
• The timeout parameter in the call_func_with_timeout function of the Executor struct has been replaced with the timeout parameter of type std::time::Duration.
• The timeout parameter in the call_func_async_with_timeout function of the Executor struct has been replaced with the timeout parameter of type std::time::Duration.
• The timeout parameter in the run_func_with_timeout function of the Func struct has been replaced with the timeout parameter of type std::time::Duration.
• The timeout parameter in the run_func_async_with_timeout function of the Func struct has been replaced with the timeout parameter of type std::time::Duration.
• The timeout parameter in the run_func function of the Vm struct has been replaced with the timeout parameter of type std::time::Duration.

Other changes include updating the code to use the new deadline and timeout parameters.

Potential problems:

1. The code does not handle errors that may occur when calculating the timeout duration.
2. The timeout value is expected to be in seconds, but the code assumes it is already in seconds and directly casts it to i64 and assigns it to value.it_value.tv_sec in the call_func_with_timeout and call_func_async_with_timeout functions of the Executor struct. This may cause unexpected behavior if the timeout value is not in seconds.
3. In the TimeoutFiberFuture struct, the timeout value is used for setting the timespec value of the timer. However, the code sets a minimum timeout of 100 milliseconds using timeout.max(std::time::Duration::from_millis(100)). This could cause the timer to fire prematurely if the original timeout value is less than 100 milliseconds.
4. The code does not handle potential errors that may occur when setting the timer using libc::timer_settime. If an error occurs, it returns an Err(()) without providing any information about the error that occurred.
5. There seem to be duplicate implementations of similar functionality in the code (e.g., call_func and call_func_with_timeout functions in both the Executor and Vm structs). It may be worth reviewing the code to check if these implementations can be consolidated or if there is any overlap in functionality.
6. The code does not provide any documentation or comments explaining the reasoning behind using the deadline parameter in the TimeoutFiberFuture struct instead of the timeout_sec parameter. It would be helpful to have some explanation to understand the intention behind this change.

Commit df343d91f73b4ed5341e46f9ed085cd101c74662

Key changes:

• Updated the API documentation in multiple files.
• Added a new argument async_state to various functions.

Potential problems:

• It is unclear from the patch description why the API documentation was updated. It would be helpful to have more context on the changes made to the documentation.
• The patch introduces a new async_state argument to multiple functions, but it is not clear how it is being used or what its purpose is. It may be necessary to document this addition more thoroughly or provide more context in the code comments.

Overall, the changes seem to be focused on adding support for asynchronous operations and updating the API documentation. However, more information is needed to fully understand the changes and their implications.

[apepkuss]

Please refine the description for the deadline argument. Thanks a lot!