Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XRPL-Labs Contribution #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dangell7
Copy link

@dangell7 dangell7 commented Nov 4, 2024

The contribution now has a network name "Xahau".

Explanation

Related issue

What type of PR is this

Proposed Changes

The contribution now has a network name "Xahau". 

Signed-off-by: Denis Angell <[email protected]>
Copy link
Member

juntao commented Nov 4, 2024

Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR.


Potential Issues and Errors

  1. Incorrect Network Name: The network name has been updated to "Xahau blockchain" instead of "XRPL Labs". This change could be misleading for users as XRPL (XRP Ledger) is the actual blockchain associated with "XRPL Labs".

  2. GitHub Repository Link: The GitHub repository link provided for Xahau Network is incorrect.

Most Important Findings

  1. Markdown Link Syntax Error: A critical error has been identified in the docs/contribute/users.md file where an extra [ and ] character is present in the GitHub URL for Xahau Network, causing the markdown link to be incorrectly rendered. This needs to be resolved immediately.

  2. Network Name Accuracy: The updated network name from "Ripple blockchain" to "Xahau blockchain" should not have been made as it does not accurately represent the actual project. The original name should be restored or a correct name for the project should be used.

  3. Consistency in URLs: Although implied, it is important to ensure that all URLs provided in the documentation are accurate and consistent. This PR addresses part of this but requires further verification across other sections if necessary.

Details

Commit ace168cc41c051be28346ff7553493b5beab99ca

Key Changes

  1. Network Name Update: The network name for "XRPL Labs" has been updated from "Ripple blockchain" to "Xahau blockchain".
  2. GitHub Repository Link Fix: The GitHub repository link for Xahau Network is incorrect and has been corrected.
  3. Markdown Formatting: Minor formatting adjustments in the table cell content to ensure consistency.

Commit e9aa38a5beb347791fc45cb13d11aabf9506a370

Key Changes in the Patch

  1. Fixing Markdown Link Syntax: The patch corrects a markdown link syntax issue in docs/contribute/users.md. Specifically, it removes an extra [ and ] character from the Xahau Network entry's GitHub URL.

  2. Updating Contribution Documentation: The pull request updates the "Contributors" section of the documentation to reflect current contributions, ensuring that all links are valid and up-to-date.

  3. Consistency in URLs: While not explicitly mentioned, there is an implied improvement in consistency across the URLs provided in the table.

@hydai
Copy link
Member

hydai commented Nov 5, 2024

Hi @dangell7
I am sorry that I cannot find any relationship between the old and new ones. Could you please provide some context that the previous project has already been renamed to the new one?

@dangell7
Copy link
Author

dangell7 commented Nov 5, 2024

Hi @dangell7 I am sorry that I cannot find any relationship between the old and new ones. Could you please provide some context that the previous project has already been renamed to the new one?

Maybe this website would help? https://xahau.network/

@WietseWind can you help clarify this? Should we add something to the old github repo? Maybe archive it?

docs/contribute/users.md Outdated Show resolved Hide resolved
Signed-off-by: Denis Angell <[email protected]>
@hydai
Copy link
Member

hydai commented Nov 29, 2024

@alabulei1 PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants