-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added contents for testing of wasmedge #197
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The pull request titled "feat: added contents for testing of wasmedge" includes several key changes related to the documentation for testing in the WasmEdge project. After reviewing the individual summaries, it is apparent that there are no potential problems or errors identified in this pull request. The most important findings include the following:
Overall, this pull request aims to improve the testing documentation in the WasmEdge project. It is recommended to carefully review and test the added contents, provide more detailed explanations and examples, and ensure the correctness of the code examples and functions mentioned in the documentation. DetailsCommit 298e985a4284c0c4e83c15f72f153140e65abd73Key Changes:
Potential Problems:
Suggestions:
Commit 57185441c321037457908c246f5910d88b244fd1Key changes in the patch:
Potential problems:
Commit f9203f0be57014e1da21772603c04f70a2e52649Key Changes:
Potential Problems:
Overall, this pull request updates the documentation related to testing in the WasmEdge project. The changes provide clearer descriptions and instructions for writing tests and where to add them. Commit e38054737035af4c7b5ac32a0ab6af661d17b7adKey changes:
Potential problems:
Overall, this patch is straightforward and solves the issue of broken links in the Commit 4e017860741f9f537bd7cdd8bd6cd844648eedabKey Changes:
Potential Problems:
Overall, the changes made in this pull request update the documentation to reflect the correct terminology and make it more accurate for the purpose of writing tests for WebAssembly code and plugins. The changes seem appropriate and do not introduce any potential problems. |
CI is failing which is expected as I removed the old |
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Can you also mention that we use codedev to auto test the test cases for the WasmEdge. https://app.codecov.io/gh/WasmEdge/WasmEdge |
@alabulei1 Okay sure, will mention that too |
You didn't make any changes. Right? @adithyaakrishna Please check out my comments. We don't need other iirrelevant content in this guide. |
Signed-off-by: Adithya Krishna <[email protected]>
@alabulei1 I hadn't done pushed the changes I did, but have updated it with the above commit. Could you please review it again? |
|
||
# Example Test Explaination | ||
|
||
The provided code snippet is a C++ test suite for a WebAssembly module, specifically focusing on a logging functionality within the WasmEdge runtime environment. It uses Google Test (gtest) for structuring and executing the tests. Let's break down the code into its key components for a clearer understanding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the code source?
|
||
> Note: You can add the documentation in the plugin test folders you create | ||
|
||
### Blogs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I don't think we need this.
### Code Explanation and Comments | ||
|
||
The provided code snippet demonstrates how to set up and execute tests for a WebAssembly code or the plugins you create, specifically using the WasmEdge runtime. The code is structured into two main parts: the test setup and the test cases themselves. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here, what's the difference between example.md and testing.md
Description:
This PR adds the written content for testing of WasmEdge software with the explanation of an example code for
test/plugins/wasi_logging
PS. This is a draft that needs to be improved and coming from a person who got started with C++ testing