Fix deeply nested prose breaking pdflatex #147
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
approved these changes
Feb 6, 2025
| @@ -298,7 +298,18 @@ | |||
|
|
|||
| # Additional stuff for the LaTeX preamble. | |||
| # Don't type-set cross references with emphasis. | |||
There was a problem hiding this comment.
Can you update this comment?
There was a problem hiding this comment.
I've updated the comment, mentioning the enumitem package.
|
@rossberg can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146, this fixes the issue around deeply nested prose breaking the PDF backend.
Briefly, PDF is generated by:
spliced rST -- Sphinx --> TEX -- pdflatex --> PDF, and previously > 5 levels of nesting of ordered lists broke pdflatex. This PR adds LaTeXenumitempackage to the preamble of Sphinx configuration to allow more levels of prose nesting.This is not the best solution to fix the problem, e.g., we may optimize the generated prose to remove redundant nestings. Yet this is a quick alternative for the time being.