Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helper privacy functions in GetPockets #12853

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Use helper privacy functions in GetPockets #12853

merged 2 commits into from
Apr 16, 2024

Conversation

turbolay
Copy link
Collaborator

Fixes #12852

@turbolay turbolay requested a review from RolandUI April 16, 2024 04:37
@turbolay
Copy link
Collaborator Author

Tests are broken on master, not related to this PR

@RolandUI
Copy link
Contributor

WalletWasabi.Tests.UnitTests.Transactions.TransactionProcessorTests.GetPocketsAsync is failing on osx and Windows (but not on Linux?!)

@turbolay
Copy link
Collaborator Author

Tests are broken on master, not related to this PR

@soosr Obviously I clicked on Linux result to write this message, you can't make this up xD
Will fix

@RolandUI
Copy link
Contributor

cACK, cannot test.

@turbolay
Copy link
Collaborator Author

GetPocketsAsync is fixed, waiting on tests + fix of HWI tests on master to re-run CI

RolandUI
RolandUI approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@RolandUI RolandUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, although I cannot verify it with testing. Feel free to merge @turbolay if you are sure.

@RolandUI
Copy link
Contributor

GetPocketsAsync is fixed, waiting on tests + fix of HWI tests on master to re-run CI

Opened a separate issue for it #12855. Don't have to hold back this PR

turbolay
turbolay commented Apr 16, 2024
View reviewed changes
Copy link
Collaborator Author

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

CleanShot.2024-04-16.at.01.05.37.mp4

@turbolay turbolay merged commit 11a20df into WalletWasabi:master Apr 16, 2024
7 of 8 checks passed
@RolandUI
Copy link
Contributor

Could you create a PR for the release branch?

@turbolay turbolay mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandUI RolandUI RolandUI approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Funds are in private pocket before safety coinjoin has completed
2 participants
@turbolay @RolandUI