-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.7.2 #688
Conversation
pedrouid
commented
Jan 5, 2022
•
edited
Loading
edited
- replace bn.js with BigInt
- replace query-string with URLSearchParams
In the @walletconnect/[email protected], query-string accounts for 4.3% of the overall bundle size. However, client-side support for URLSearchParams has reached mainstream and so we can just use it instead of including more bundle-size-increasing dependencies. - Fixes #667
- Fixes #669
Replace bn.js with BigInt
This pull request is being automatically deployed with Vercel (learn more). react-app – ./examples/react-app🔍 Inspect: https://vercel.com/walletconnect/react-app/4Q7FhELaWG5wdcw4E3gYQAFHUxmV [Deployment for a2c16f6 failed] react-wallet – ./examples/react-wallet🔍 Inspect: https://vercel.com/walletconnect/react-wallet/GWYbm7ppAzjWjdcKv7Jxo3Vtvyo3 [Deployment for a2c16f6 failed] canary-react-app – ./examples/react-app🔍 Inspect: https://vercel.com/walletconnect/canary-react-app/6bW5qEsXJ9NN5hxNgCpSYVhDZht7 [Deployment for a2c16f6 failed] canary-react-wallet – ./examples/react-wallet🔍 Inspect: https://vercel.com/walletconnect/canary-react-wallet/45Bp1DecHjHZrEhesXn6kKxsi6f8 [Deployment for a2c16f6 failed] |
Rm query-string and use URLSearchParams
@TimDaub you can see below a comparison between v1.7.1 and v1.7.2-rc.0 which includes both PRs you have submitted and we can see substantial bundle reduction 💪 Thanks a lot for your contributions! Only thing missing now is testing agaisnt react-native applications to support as low as v0.60 potentially |
wow this is super cool! thanks for sharing @pedrouid |
@pedrouid Tested these cases with react native running on hermes engine
So overall this whole change would be breaking rn |
That's a shame! We will need to develop separate target libraries to support these changes for NodeJS and Browser while still using the current dependencies for React-Native |