Remove type declaration for a module in types package

[mmv08]

In the current form, the declaration overwrites types for modules named @walletconnect/types, this makes it impossible to properly integrate walletconnect v1 and v2 in the same app, so if you'd try to import types for v2 it will resolve to v1 types.

Required for safe-global/safe-react-apps#178

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-app – ./examples/react-app

🔍 Inspect: https://vercel.com/walletconnect/react-app/8ePHkjJSFJSBAAiQBB8GW7Zj1SjR
✅ Preview: Failed

[Deployment for 0a1ad1f failed]

react-wallet – ./examples/react-wallet

🔍 Inspect: https://vercel.com/walletconnect/react-wallet/aCFy4FXEbGwrACLDF63FEDwEm9m7
✅ Preview: Failed

[Deployment for 0a1ad1f failed]

[mmv08]

npx tsc in the build step asked me to install typescript first

[pedrouid]

What I've been recommending instead is that you install using NPM aliases not only for the client but also for it's dependencies.

    "@walletconnect/client": "1.6.6",
    "@walletconnect/types": "1.6.6",
    "@walletconnect/utils": "1.6.6",
    "@walletconnect/v2-client": "npm:@walletconnect/[email protected]",
    "@walletconnect/v2-types": "npm:@walletconnect/[email protected]",
    "@walletconnect/v2-utils": "npm:@walletconnect/[email protected]",

I know it's not a perfect solution nor the best developer experience but we intend to improve this 🙏

[mmv08]

What I've been recommending instead is that you install using NPM aliases not only for the client but also for it's dependencies.

    "@walletconnect/client": "1.6.6",
    "@walletconnect/types": "1.6.6",
    "@walletconnect/utils": "1.6.6",
    "@walletconnect/v2-client": "npm:@walletconnect/[email protected]",
    "@walletconnect/v2-types": "npm:@walletconnect/[email protected]",
    "@walletconnect/v2-utils": "npm:@walletconnect/[email protected]",

I know it's not a perfect solution nor the best developer experience but we intend to improve this 🙏

This is hacky and does not fix the issue. What's wrong with merging my PR that fixes the problem? You don't need to include module declaration for types package because that's literally what the type package is for.

[mmv08]

@pedrouid Could you please take another look? I believe the current type packages users declare statement wrongly and blocks v2 integration

[pedrouid]

Thanks for the PR @mikheevm 🙌 I will handle this on the next branch

[pedrouid]

Check commit ea0d4e3

[mmv08]

thank you!