Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix measure handshake latency measurement in canary #5510

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

chris13524
Copy link
Member

Description

Updates the metrics for measuring handshake latency. Since the relay connection is now deferred it made the handshake measurement incorrect since it was measuring SDK initialization time. This PR fixes the measurement by triggering a connection explicitly. This PR also adds a new measurement for the SDK initialization time because it appears to be non-zero.

Slack conversation

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)

How has this been tested?

Not tested

@chris13524 chris13524 self-assigned this Nov 20, 2024
@arein arein added the accepted label Nov 20, 2024
@chris13524 chris13524 merged commit 56080bb into v2.0 Nov 20, 2024
13 checks passed
@chris13524 chris13524 deleted the chore/canary-measure-connect-time branch November 20, 2024 18:39
@ganchoradkov ganchoradkov mentioned this pull request Dec 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants