fix: subscriber publish fail #5433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -236,6 +236,7 @@ export class Subscriber extends ISubscriber { | |||
| }; | |||
| this.logger.debug(`Outgoing Relay Payload`); | |||
| this.logger.trace({ type: "payload", direction: "outgoing", request }); | |||
| const shouldThrow = opts?.internal?.throwOnFailedPublish; | |||
There was a problem hiding this comment.
this is true by default now, right? Would it cause issues in wallets that upgrade to this version? 🤔
There was a problem hiding this comment.
nope. It would raise early feedback if there are network issues
ignaciosantise
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed an issue where failed subscription attempts were retried instead of throwing an error
Type of change
How has this been tested?
tests and in canary -
2.17.1-canary-0Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.