Fix: 1271 sig validation chainId validation #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganchoradkov
changed the title
Cali93
reviewed
Oct 8, 2024
| const parsedChain = parseChainId(chainId); | ||
| if (!parsedChain.namespace || !parsedChain.reference) { | ||
| throw new Error( | ||
| `isValidEip1271Signature failed: chainId must be in CAIP-2 format, received: ${chainId}`, |
There was a problem hiding this comment.
Why should it be in CAIP-2 format since EIP-1271 signature is specific to EVM ?
There was a problem hiding this comment.
blockchain api rejects the request if it isnt. Probably we can update there it there.
There was a problem hiding this comment.
Wouldn't this be a breaking change if someone provides a custom RPC url and is sending the non compliant CAIP-2 chain ID ?
There was a problem hiding this comment.
it shouldn't. These params are opinionated for our rpc api. Direct node urls do not use them
Cali93
approved these changes
Oct 9, 2024
| const parsedChain = parseChainId(chainId); | ||
| if (!parsedChain.namespace || !parsedChain.reference) { | ||
| throw new Error( | ||
| `isValidEip1271Signature failed: chainId must be in CAIP-2 format, received: ${chainId}`, |
There was a problem hiding this comment.
Wouldn't this be a breaking change if someone provides a custom RPC url and is sending the non compliant CAIP-2 chain ID ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where we were not passing CAIP2 formatted
chainIdfor 1271 signature validationType of change
How has this been tested?
tests
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.