Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dot-org): use walletconnect.org for the relay and rpc urls #5393

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore(dot-org): use walletconnect.org for the relay and rpc urls #5393

merged 1 commit into from
Sep 26, 2024

Conversation

Cali93
Copy link
Contributor

@Cali93 Cali93 commented Sep 26, 2024

Description

We should use walletconnect.org everywhere.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)

How has this been tested?

Covered by existing tests

Fixes/Resolves (Optional)

Users in some regions getting blocked by their ISPs

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Cali93 Cali93 requested a review from ganchoradkov September 26, 2024 09:24
ganchoradkov
ganchoradkov approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

ganchoradkov
ganchoradkov approved these changes Sep 26, 2024
View reviewed changes
packages/utils/test/cacao.spec.ts Outdated Show resolved Hide resolved
bkrem
bkrem approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Cali93 Cali93 merged commit 2f95413 into v2.0 Sep 26, 2024
9 checks passed
@Cali93 Cali93 mentioned this pull request Sep 27, 2024
Merged
20 tasks
@ganchoradkov ganchoradkov mentioned this pull request Oct 1, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

@bkrem bkrem bkrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cali93 @bkrem @ganchoradkov