New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sets domain if available else sets `sp` #5370

Merged

ganchoradkov merged 2 commits into v2.0 from fix/init-event

Sep 18, 2024

Member

ganchoradkov commented Sep 18, 2024

Description

Sets required event param domain if available else sets sdk platform to dekstop
context https://walletconnect.slack.com/archives/C03RME3BS9L/p1726646431144139

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

dogfooding

Checklist

I have performed a self-review of my own code
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.


          fix: sets domain if available else sets sp

a9738e9

ganchoradkov requested a review from Cali93

September 18, 2024 08:33

arein added the accepted label

Cali93 approved these changes

View reviewed changes

Contributor

Cali93 left a comment

LGTM! Did you test that events are sent ?

packages/core/src/controllers/events.ts Outdated Show resolved Hide resolved


          refactor: optimize conditions

fe0e55c

ganchoradkov merged commit cb0a006 into v2.0

9 checks passed

ganchoradkov deleted the fix/init-event branch

September 18, 2024 08:51

ganchoradkov mentioned this pull request

chore: 2.16.2 release #5369

Merged

20 tasks

github-merge-queue bot referenced this pull request in valora-inc/wallet


          chore(deps): update dependency @walletconnect/react-native-compat to …

993f86b

…^2.16.2 (#6064)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://redirect.github.com/walletconnect/walletconnect-monorepo)
| [`^2.16.1` ->
`^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2)

[Compare
Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2)

#### What's Changed

- feat: init event by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343)
- feat: fetch call status via bundler url by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171)
- fix: sets domain if available else sets `sp` by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.16.1...2.16.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>

github-merge-queue bot referenced this pull request in valora-inc/wallet


          chore(deps): update dependency @walletconnect/utils to ^2.16.2 (#6065)

83c8319

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/utils](https://redirect.github.com/walletconnect/walletconnect-monorepo)
| [`^2.16.1` ->
`^2.16.2`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.16.1/2.16.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2futils/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2futils/2.16.1/2.16.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/utils)</summary>

###
[`v2.16.2`](https://redirect.github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.16.2)

[Compare
Source](https://redirect.github.com/walletconnect/walletconnect-monorepo/compare/2.16.1...2.16.2)

##### What's Changed

- feat: init event by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5343](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5343)
- feat: fetch call status via bundler url by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5171](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5171)
- fix: sets domain if available else sets `sp` by
[@&#8203;ganchoradkov](https://redirect.github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5370](https://redirect.github.com/WalletConnect/walletconnect-monorepo/pull/5370)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.16.1...2.16.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Satish Ravi <[email protected]>

Cali93 mentioned this pull request

chore: 2.16.3 release #5397

Merged

20 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels