fix: Add reject value when rejecting connection promise on transportClose #1870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On relayer
transportOpen
, when waiting forprovider.connect
to resolve, it might get stuck so there's aPromise.race
to reject the promise iftransportClosed
is called during connection.In the case of rejecting it like so, the reject is called with no value which causes the
catch
close to throw another exception (since it tried to accessmessage
of undefined) instead of handling the current one correctly.Due Diligence