Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional request expiry #1851

Merged
merged 9 commits into from
Jan 10, 2023
Merged

feat: optional request expiry #1851

merged 9 commits into from
Jan 10, 2023

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 9, 2023 •
edited by bkrem
Loading

Description

Relates to #1739

Added an optional expiry parameter to session requests where a number between 300 & 604800 seconds (5 minutes min - 7 days max) can be specified to extend a request timeout

How Has This Been Tested?

new validation + integration tests

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@arein arein added the accepted label Jan 9, 2023
@ganchoradkov ganchoradkov self-assigned this Jan 9, 2023
@ganchoradkov ganchoradkov added the type: enhancement New feature or request label Jan 9, 2023
@ganchoradkov ganchoradkov requested a review from bkrem January 9, 2023 15:15
bkrem
bkrem approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting this shipped 🚀

Relates to #1739

@ganchoradkov ganchoradkov merged commit 50bd164 into v2.0 Jan 10, 2023
@ganchoradkov ganchoradkov deleted the feat/optional-request-expiry branch January 10, 2023 08:12
@ganchoradkov ganchoradkov mentioned this pull request Jan 24, 2023
Closed
@alexjba alexjba mentioned this pull request Sep 11, 2024
Open
23 tasks
@caybro caybro mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

Assignees

@ganchoradkov ganchoradkov

Labels
accepted type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganchoradkov @bkrem @arein