fix: expirer pending requests #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrem
reviewed
Jan 6, 2023
bkrem
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue was identified with pending requests where on approving/rejecting a request was logging
{context: 'core'} {context: 'core/expirer'} 'No matching key. expirer: topic:id:1672999835033891'.The problem was caused by
formatTargetbeing called twice on the same key inexpirer.delflow thus prepending thetopic:..&id:...to the keyAdditionally, the expiration calculation was incorrect for pending requests and is also resolved in the PR
How Has This Been Tested?
dogfooding
additional test for the expirer
Due Dilligence