Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): differentiate sed command by platform #1838

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix(scripts): differentiate sed command by platform #1838

merged 2 commits into from
Jan 5, 2023

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Jan 5, 2023 •
edited
Loading

Description

  • The empty string "" parameter for sed in the update_relayer_sdk_version.sh script seems to be macOS/BSD specific.
  • Adds control flow to call on macOS with extra parameter, without by default.

How Has This Been Tested?

  • Tested on macOS via parallel GNU sed installation.

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@bkrem bkrem requested a review from ganchoradkov January 5, 2023 14:41
@arein arein added the accepted label Jan 5, 2023
ganchoradkov
ganchoradkov approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works awesome 💯 just as mentioned in private, on linux there's the warning for the incorrect syntax == should be =

@bkrem bkrem merged commit 10eb42f into v2.0 Jan 5, 2023
@bkrem bkrem deleted the fix/relayer-version-script-sed-by-platform branch January 5, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrem @ganchoradkov @arein