feat: Implement Eventemitter#removeAllListener. #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to remove all listeners for the sign client. Currently it is only possible to remove one listener at a time by passing the event it listens on and the callback function.
|
@0xasimetriq Could you pop an eye on this please? :) |
bkrem
approved these changes
Dec 19, 2022
ganchoradkov
approved these changes
Dec 19, 2022
antondalgren
requested review from
bkrem and
ganchoradkov
and removed request for
bkrem and
ganchoradkov
|
Sorry for the spam 😅 ☝️ |
antondalgren
requested review from
ganchoradkov
and removed request for
bkrem
ganchoradkov
approved these changes
Dec 20, 2022
|
Can we try and get this into a release this week? :) |
@antondalgren shipped as part of https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.1.5 🎁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to remove all listeners for the sign client. Currently it is only possible to remove one listener at a time by passing the event it listens on and the callback function.
Resolves #1761
How Has This Been Tested?
Locally in my own app, it works smoothly.
Due Dilligence