Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): auto-update RELAYER_SDK_VERSION as part of new-version #1731

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Dec 7, 2022

Description

No more manually updating finally 🤞

How Has This Been Tested?

  • Locally
  • Do a fresh clone of the repo and ensure the script runs out of the box as expected

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@bkrem bkrem requested a review from ganchoradkov December 7, 2022 17:20
@arein arein added the accepted label Dec 7, 2022
@bkrem bkrem marked this pull request as ready for review December 8, 2022 11:44
@bkrem
Copy link
Member Author

bkrem commented Dec 8, 2022

@ganchoradkov just did a fresh clone of the repo and checked, seems like the script executable out of the box already without a dedicated chmod +x step on repo setup 👍

Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 🥇 💯

@bkrem bkrem force-pushed the feat/auto-update-relayer-sdk-version branch from d5e42d3 to 5f152d3 Compare December 8, 2022 11:48
@bkrem bkrem merged commit 55ac00a into v2.0 Dec 8, 2022
@bkrem bkrem deleted the feat/auto-update-relayer-sdk-version branch December 8, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants