New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update jsonrpc-ws-connection to fix various WS issues #1669

Merged

bkrem merged 1 commit into v2.0 from chore/update-jsonrpc-ws-connection

Nov 23, 2022

Member

bkrem commented Nov 23, 2022 •

edited

Loading

Description

Update core and sign-client to [email protected]
Fixes WS connection failing with opaque Cannot read property 'message' of undefined message, providing an explicit error instead
- via fix(ws): ensure we emit a meaningful error msg if socket.onerror returns none walletconnect-utils#38
Fixes the unguarded global reference raised in "typeof global.WebSocket" check in @walletconnect/jsonrpc-ws-connection is causing issues #1299
- via fix(ws): ensure undefined global is handled for WS resolution walletconnect-utils#36)

TODO

We still have to resolve the unguarded global reference in the external localStorage dependency raised in ReferenceError: global is not defined in runtime #1658

How Has This Been Tested?

Unit tests
CI
Dogfooding with a canary

Due Dilligence

Breaking change
Requires a documentation update
Requires a e2e/integration test update


          chore(deps): update jsonrpc-ws-connection

1edb9cd

bkrem requested a review from ganchoradkov

November 23, 2022 16:30

arein added the accepted label

ganchoradkov approved these changes

View reviewed changes

Member

ganchoradkov left a comment

thanks for solving! It's been bugging the community for a long time 💯

bkrem merged commit 7115a25 into v2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels