Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting errors, async issues async not needed or await missing #1563

Merged
merged 1 commit into from
Nov 1, 2022
Merged

linting errors, async issues async not needed or await missing #1563

merged 1 commit into from
Nov 1, 2022

Conversation

bws9000
Copy link
Contributor

@bws9000 bws9000 commented Oct 29, 2022 •
edited
Loading

Description

Screen Shot 2022-10-29 at 5 13 13 PM

I was just interested in your project. I ran npm run check and noticed some linting warnings probably overlooked while refactoring no be deal

Universal provider

  • added await to line 53. This await probably not needed or async
  • added await to line 100. It appears you might need one there
  • line 139 removed async, no need for it there it looks like

eip155

  • added await to line 51, i'm assuming you want one there

removed linting warnings

Resolves:
No related issue

@ganchoradkov ganchoradkov self-requested a review October 31, 2022 07:46
ganchoradkov
ganchoradkov approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@ganchoradkov ganchoradkov merged commit 39d8da0 into WalletConnect:v2.0 Nov 1, 2022
@bws9000 bws9000 deleted the minor-linting-async branch November 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bws9000 @ganchoradkov