Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fixes stale keyvaluestorage storage due to types deps #1535

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Oct 15, 2022

Description

  • While dogfooding the pairing API in the example dapp, I noticed that there still seemed to be an implicit need for better-sqlite3
  • This came from @walletconnect/types still depending on @walletconnect/[email protected] (see yarn why output below)
➜ yarn why @walletconnect/keyvaluestorage      
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "@walletconnect/keyvaluestorage"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "@walletconnect/[email protected]"
info Has been hoisted to "@walletconnect/keyvaluestorage"
info Reasons this module exists
   - Hoisted from "@walletconnect#types#@walletconnect#keyvaluestorage"
   - Hoisted from "@walletconnect#auth-client#@walletconnect#utils#@walletconnect#types#@walletconnect#keyvaluestorage"
info Disk size without dependencies: "568KB"
info Disk size with unique dependencies: "744KB"
info Disk size with transitive dependencies: "744KB"
info Number of shared dependencies: 2
=> Found "@walletconnect/core#@walletconnect/[email protected]"
info This module exists because "@walletconnect#core" depends on it.
info Disk size without dependencies: "488KB"
info Disk size with unique dependencies: "664KB"
info Disk size with transitive dependencies: "664KB"
info Number of shared dependencies: 2
=> Found "@walletconnect/core#@walletconnect/types#@walletconnect/[email protected]"
info This module exists because "@walletconnect#core#@walletconnect#types" depends on it.
info Disk size without dependencies: "568KB"
info Disk size with unique dependencies: "744KB"
info Disk size with transitive dependencies: "744KB"
info Number of shared dependencies: 2
=> Found "@walletconnect/sign-client#@walletconnect/[email protected]"
info Reasons this module exists
   - "@walletconnect#sign-client#@walletconnect#core" depends on it
   - Hoisted from "@walletconnect#sign-client#@walletconnect#core#@walletconnect#keyvaluestorage"
info Disk size without dependencies: "488KB"
info Disk size with unique dependencies: "664KB"
info Disk size with transitive dependencies: "664KB"
info Number of shared

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@bkrem bkrem requested a review from ganchoradkov October 15, 2022 21:39
@arein arein added the accepted label Oct 15, 2022
@bkrem bkrem merged commit 27bb0c8 into v2.0 Oct 21, 2022
@bkrem bkrem deleted the fix/stale-keyvaluestorage-deps branch October 21, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants