Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: speed up validation tests #1515

Merged
merged 2 commits into from
Oct 6, 2022
Merged

fix: speed up validation tests #1515

merged 2 commits into from
Oct 6, 2022

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Oct 6, 2022 •
edited
Loading

Description

Speeds up validation tests by initializing test clients once per describe section instead of once per test

Local env test duration before improvements: ~116s
Local env test duration after improvements: ~8s

How Has This Been Tested?

npm run test

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@ganchoradkov ganchoradkov added the type: enhancement New feature or request label Oct 6, 2022
@ganchoradkov ganchoradkov self-assigned this Oct 6, 2022
@arein arein added the accepted label Oct 6, 2022
@ganchoradkov
Copy link
Member Author

on the rs-relay side the full test suite duration went from ~7m to ~2m

@ganchoradkov ganchoradkov merged commit f544fbe into v2.0 Oct 6, 2022
@ganchoradkov ganchoradkov deleted the fix/speed-up-validation-tests branch October 6, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

Assignees

@ganchoradkov ganchoradkov

Labels
accepted type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganchoradkov @arein