-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caip222 over universal linking #1361
Conversation
…V2 into caip222-over-universal-linking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass, a few small things, most of them should probably be deferred to follow up PRs.
Great work on this, couldn't be more excited to see this so close to landing 🚀
Example/DApp/Modules/Sign/SessionAccount/SessionAccountPresenter.swift
Outdated
Show resolved
Hide resolved
Sources/WalletConnectSign/Auth/Services/App/AuthResponseSubscriber.swift
Show resolved
Hide resolved
Sources/WalletConnectSign/Auth/Services/App/AuthResponseSubscriber.swift
Outdated
Show resolved
Hide resolved
let requestParams = [EthSendTransaction.stub()] | ||
let responseParams = "0xdeadbeef" | ||
|
||
let semaphore = DispatchSemaphore(value: 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth looking into an alternative approach to validate the order of expectations.
Sources/WalletConnectSign/LinkAndRelayDispatchers/SessionRequester.swift
Outdated
Show resolved
Hide resolved
Sources/WalletConnectSign/LinkAndRelayDispatchers/SessionRequestDispatcher.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack Pooley <[email protected]>
…iber.swift Co-authored-by: Jack Pooley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality Gate failedFailed conditions |
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence