User defaults group migration #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V2 into user-defaults-group-migration
llbartekll
commented
Nov 28, 2023
flypaper0
reviewed
Nov 29, 2023
flypaper0
reviewed
Nov 29, 2023
| @@ -8,13 +8,20 @@ public class Networking { | |||
| } | |||
|
|
|||
| public static var interactor: NetworkingInteractor = { | |||
| guard let _ = Networking.config else { | |||
flypaper0
reviewed
Nov 29, 2023
| }() | ||
|
|
||
| public static var groupIdentifier: String { | ||
| guard let config = Networking.config else { |
There was a problem hiding this comment.
we're copy and pasting fatal error. May be create private static var config: Config and throw fatal error only there?
flypaper0
reviewed
Nov 29, 2023
flypaper0
reviewed
Nov 29, 2023
|
|
||
| let keychainStorage = KeychainStorage(serviceIdentifier: "com.walletconnect.sdk") | ||
| let keyValueStorage = UserDefaults.standard | ||
| let keyValueStorage = UserDefaults(suiteName: groupIdentifier) ?? UserDefaults.standard |
flypaper0
reviewed
Nov 29, 2023
flypaper0
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence