-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WalletApp] Handle removed session request #1232
Conversation
@@ -281,3 +281,12 @@ private extension SessionEngine { | |||
onEventReceived?(topic, event.publicRepresentation(), payload.request.chainId) | |||
} | |||
} | |||
|
|||
extension SessionEngine.Errors: LocalizedError { | |||
var errorDescription: String? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better to use WalletConnectError? we have noSessionMatchingTopic
for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno whether it's better, the SessionEngine
has its own Errors
. Should I remove this error from SessionEngine
then?
extension SessionEngine.Errors: LocalizedError { | ||
var errorDescription: String? { | ||
switch self { | ||
case .sessionRequestExpired: return "Session request expired" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also can be moved in WalletConnectError imo
Fix for https://walletconnect.slack.com/archives/C03S6NN8NHF/p1699699835241069
Due Dilligence