Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit Conversion From String Should be Removed #47

Closed
WalkerCodeRanger opened this issue Oct 24, 2019 · 1 comment
Closed

Implicit Conversion From String Should be Removed #47

WalkerCodeRanger opened this issue Oct 24, 2019 · 1 comment
Labels
breaking change enhancement next-major-version
Milestone
v3.0.0

Comments

@WalkerCodeRanger
Copy link
Owner

Per the discussion in PR #25, the implicit conversion to string should be removed. First, it shouldn't be an implicit conversion because it can fail. But even if it were an explicit conversion, that would be inconsistent with the .NET framework style. For an infrequently used library, consistency is more valuable than any convenience that might be gained.

Issue #46 is to mark the conversion [Obsolete]. This issue is to remove it.
@WalkerCodeRanger WalkerCodeRanger added this to the v3.0.0 milestone Oct 24, 2019
@WalkerCodeRanger WalkerCodeRanger changed the title Implicit Coversion From String Should be Removed Implicit Conversion From String Should be Removed Oct 24, 2019
WalkerCodeRanger added a commit that referenced this issue Jan 16, 2023
@WalkerCodeRanger
remov implicit conversion from string issue #47
557e2c4
WalkerCodeRanger added a commit that referenced this issue Jan 22, 2023
@WalkerCodeRanger
remove implicit conversion from string issue #47
d546761
@WalkerCodeRanger
Copy link
Owner Author

Removed on master and will be included in v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement next-major-version
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@WalkerCodeRanger