Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows Construction of SemVersion with Negative Major, Minor, Patch #40

Closed
WalkerCodeRanger opened this issue Oct 12, 2019 · 2 comments
Closed

Allows Construction of SemVersion with Negative Major, Minor, Patch #40

WalkerCodeRanger opened this issue Oct 12, 2019 · 2 comments
Labels
breaking change bug next-major-version
Milestone
v3.0.0

Comments

@WalkerCodeRanger
Copy link
Owner

The primary constructor allows the construction of a SemVersion instance with negative values for Major, Minor, and Patch.
@WalkerCodeRanger WalkerCodeRanger added this to the v3.0 milestone Oct 12, 2019
WalkerCodeRanger added a commit that referenced this issue Oct 24, 2019
@WalkerCodeRanger
tests for issue #40 construct with negative values
8101c20
@WalkerCodeRanger
Copy link
Owner Author

One constructor overload that allows this has been marked obsolete. However, for backward compatibility other overloads had to be added that also have this issue.

@WalkerCodeRanger
Copy link
Owner Author

This has been fixed on master and will be included in v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug next-major-version
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@WalkerCodeRanger